? ? Pending

User tests: Successful: Unsuccessful:

avatar jeffda
jeffda
13 Dec 2016

Remove

wrapper injected by editors like TinyMCE.

avatar jeffda jeffda - open - 13 Dec 2016
avatar jeffda jeffda - change - 13 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2016
Category Front End Plugins
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Labels Added: ?
avatar jeckodevelopment
jeckodevelopment - comment - 13 Dec 2016

Can you please add a Summary of what this PR does and test instructions for it, following the PR template for this repo?
Thank you!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13191.

avatar C-Lodder
C-Lodder - comment - 13 Dec 2016

Testing instructions (from what I think the code does):

  • Open an Article in the Article Manager
  • Add {loadposition XXX} via the source code in TinyMCE (or codemirror instead)
  • Add <p>{loadposition XXX}</p> via the source code in TinyMCE (or codemirror instead)
  • Ensure both modules are visible in the frontend
avatar ggppdk
ggppdk - comment - 13 Dec 2016

I guess you want to remove the P tag,
added by the HTML editor when you press enter to go to the next line

It is not proper way to remove HTML code for 1 specific case there,
it looks very much like an unneeded hack

-- what if, instead of P, the default wrapping TAG of the editor was configured to be DIV or other ?
-- plus how do you disguish the cases that P tag, was added intentionally ?

If you want to remove the styling adding by the P
-- you can edit the HTML and change it to DIV, which (usually) by default has no styling assigned to it
(and if tinyMCE sees that a DIV is already there then it will not add a P)

but i do understand that the default wrapping TAG is P, and usually Joomla templates, by default,
they do add some styling for the P tag (e.g. padding), and this is an annoyance

avatar dgt41
dgt41 - comment - 14 Dec 2016

Totally agree with @ggppdk here. Also the proposed code will break on all other editors or tinyMCE with div as the wrapping tag

avatar jeckodevelopment
jeckodevelopment - comment - 14 Dec 2016

Closing because:

will break on all other editors or tinyMCE with div as the wrapping tag

avatar jeckodevelopment jeckodevelopment - close - 14 Dec 2016
avatar jeckodevelopment jeckodevelopment - change - 14 Dec 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-12-14 00:39:19
Closed_By jeckodevelopment
Labels Added: ?

Add a Comment

Login with GitHub to post a comment