[#13190] - Remove unnecessary parentheses in site components
- Fixed in Code Base
- 14 Dec 2016
- Medium
- Build: staging
- # 13190
- Diff
- frankmayer:remove-unnecessary-parentheses-in-site-components
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
- Removed unnecessary parentheses in site components
This PR is part of a set to try to separate some of the changes done in some of my previous batch PR's for site/components, which are still on hold (#12290, #12292, #12293, #12294).
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners com_config com_contact com_content com_finder com_newsfeeds com_tags com_users |
| Labels |
Added:
?
|
||
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13190.
can't we also chnage the and and or to && and || at the same time?
I think this should be normalised.
and remove spaces here: isset( $obj->{'image_intro'} ) in two places?
@infograf768 Let's do this in another PR. This also might need some discussion. I want to keep these PRs streamlined, so that they can be accepted faster.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13190.
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13190.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13190.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-14 20:17:55 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on 3b3a4b7
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13190.