User tests: Successful: Unsuccessful:
Pull Request for Issue #13166.
Apply the test and try the calendar (e.g. article edit
Status | New | ⇒ | Pending |
Category | ⇒ | Layout JavaScript |
Labels |
Added:
?
|
Category | Layout JavaScript | ⇒ | Layout JavaScript Unit Tests |
Sure, any suggestion?
@andrepereiradasilva I'll do a general style clean up once @dgt41 is happy with the rest!
@dgt41 Did you have a chance to look at the colspan count in the time tr when there is no 'wk' column?..
<tr class="time">
<td class="time time-title" colspan="1">Time:</td>
<td class="time hours-select" colspan="2"> .. </td>
<td class="time minutes-select" colspan="2"> .. </td>
<td class="time ampm-select" colspan="3"> </td>
</tr>
All colspan should total 7 not 8. This would allow us to fix the un-even column widths.
Labels |
Added:
?
|
@schnuti Nothing missed.. you have highlighted a potential issue.
The calendar displays above the field if there is not enough space in the viewport to display below it...
@dgt41 Would it be possible to disable this in the JS? Appears to be adding a minus margin-top if the space below is not available. If not you could override it with CSS...
.js-calendar {
margin-top: 0 !important;
}
Here the display above happens when one has chnaged the window size and did not reload the page. After reload, the calendar displays normally.
My screenshots above come from my "normal" full screen Firefox. (Bootstrap is not collapsed) I now tested to enlarge the viewport. After clicking CTRL + - three (3) times and page reload, the pop-ups appears in full below the fields.
In frontend (Protostar as is) "Create Article" shows the "Start Publishing" above and "Finish Publishing" below the field. "Finish Publishing" enlarges the scrollable area. A trick is, that you can't scroll by clicking the scrollbar. By using the mouse-wheel I can scroll down (or up) to see the pop-up in full.
@dgt41 Personally I wouldn't be a fan of moving the calendar with the viewport. My reasoning been that if a user decides to scroll while the calendar is opened, one can only presume that the calendar is no longer their focus.
A solution to the issue would be to only display the calendar above the field if the space is not available below within the entire page rather than just the viewport.
I have tested this item
This fixes the issue I reported in #13166
Just one note, when I click "Today" I would assume I would be taken to today, highlighted, and the calendar stay open. It closes. This is against my expectation, dunno if others think that way though.
I have tested this item
Test OK
@jeckodevelopment done
I have tested this item
again conflicts Dimitris!
I have tested this item
I cannot set year of Created Date. Zoom is 100%.
Only issue there is your effecting the remaining content of the page which may cause some random issues depending on the content following the calendar field.
Quote
I think disabling this is the way to go. At least then the calendar will always be accessible even thou in some cases the user may have to scroll.
Be still aware that clicking the scrollbar closes the pop-up and any expanded part of the viewport. i.e. If there is not enough space in the viewport below the field the user has to use alternative scrolling methods. If available - mouse wheel or ...?
I have tested this item
I have tested successfully
I have tested this item
We have testet succesfully on Firefox and Chrome on Windows and Linux
testet by jc17de
Milestone |
Added: |
||
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 23:25:40 |
Closed_By | ⇒ | wilsonge | |
Labels |
Please fix travis error.
Line:1509 JS file "calendar-vanilla.min.js" should be loaded
Failed asserting that an array has the key '/media/system/js/fields/calendar-vanilla.min.js'.
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/html/JHtmlTest.php:1510
I fixed the test
Great
@dgt41 didn't test this, but can't we get a better color than this lime fluorescent green ... ?