? ? Success

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
10 Dec 2016

Replacements for deprecated JApplication::getHash()

avatar frankmayer frankmayer - open - 10 Dec 2016
avatar frankmayer frankmayer - change - 10 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2016
Category Libraries Unit Tests
avatar mbabker
mbabker - comment - 10 Dec 2016

Can you revert the changes in the test class? Even though it's deprecated that helps to make sure the old code doesn't unexpectedly break for whatever reason.

avatar frankmayer frankmayer - change - 10 Dec 2016
Labels Added: ? ?
avatar frankmayer
frankmayer - comment - 10 Dec 2016

@mbabker Yes, you're right.
I reverted the changes in the test for the deprecated one and added a new test for the new implementation.

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Dec 2016

I have tested this item successfully on 8bf68e7

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13162.

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 14 Dec 2016

I have tested this item successfully on 8bf68e7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13162.

avatar laoneo laoneo - test_item - 14 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 14 Dec 2016
Status Pending Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 14 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13162.

avatar jeckodevelopment jeckodevelopment - change - 14 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - change - 14 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-14 20:06:38
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar rdeutz rdeutz - reference | 406821d - 14 Dec 16
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar frankmayer frankmayer - head_ref_deleted - 14 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment