? ? Pending

User tests: Successful: Unsuccessful:

avatar frankmayer
frankmayer
10 Dec 2016

Replaces deprecated getCfg() with get()

avatar frankmayer frankmayer - open - 10 Dec 2016
avatar frankmayer frankmayer - change - 10 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Dec 2016
Category Libraries Unit Tests
avatar frankmayer frankmayer - change - 10 Dec 2016
Labels Added: ? ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Dec 2016

I have tested this item successfully on 6ba6499

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13161.

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Dec 2016 - Tested successfully
avatar frankmayer
frankmayer - comment - 14 Dec 2016

Should I close this one, and make a new PR against 4.0? Opinions?

avatar andrepereiradasilva
andrepereiradasilva - comment - 14 Dec 2016

why?

avatar frankmayer
frankmayer - comment - 14 Dec 2016

Forget it, thought it was deprecating for 4.0 also. It's just that I have so many PRs and branches lying around... want to get at least the smaller ones get merged ?

avatar Bakual Bakual - change - 14 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-14 19:59:39
Closed_By Bakual
avatar Bakual Bakual - close - 14 Dec 2016
avatar Bakual Bakual - merge - 14 Dec 2016
avatar Bakual Bakual - reference | f58dd76 - 14 Dec 16
avatar Bakual Bakual - merge - 14 Dec 2016
avatar Bakual Bakual - close - 14 Dec 2016
avatar Bakual Bakual - change - 14 Dec 2016
Milestone Added:
avatar frankmayer
frankmayer - comment - 14 Dec 2016

@Bakual Thanks ?

avatar frankmayer
frankmayer - comment - 14 Dec 2016

@bakual It is a pleasure ?
... and thanks for the prompt merging just now.
Now, to be able to continue doing those mass things, I would need to get as many as possible of my other PR's closed, too, in order to avoid constant conflict resolution. It would be great if we could get those things merged as soon as possible.

avatar frankmayer frankmayer - head_ref_deleted - 14 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment