[#13156] - Replace deprecated isSite() and isAdmin() calls
- Fixed in Code Base
- 20 Dec 2016
- Medium
- Build: staging
- # 13156
- Diff
- frankmayer:issite-conversion
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As the title says, it replaces the deprecated isSite() and isAdmin() calls with the new ones
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_finder com_login com_media com_menus com_modules Templates (admin) Front End com_config com_tags com_users Libraries External Library |
| Labels |
Added:
?
|
||
| Category | Administration com_categories com_contact com_content com_finder com_login com_media com_menus com_modules Templates (admin) Front End com_config com_tags com_users Libraries External Library | ⇒ | Administration com_categories com_contact com_content com_finder com_login com_media com_menus com_modules Templates (admin) Front End com_config com_tags com_users Libraries |
hmm... why was that deprecated?
This passes for now, but only after I reverted the changes in 'libraries/cms/pagination/pagination.php'
Has anyone any idea why the replacements failed there?
hmm, I think I know why... checking it out
It allows having custom clients (like CLI applications) that don't need to try and implement these custom isSite() and isAdmin() methods.
@frankmayer i think you missed some.
/libraries/joomla/document/renderer/html/modules.php:37
/libraries/joomla/cache/cache.php:702
/libraries/joomla/cache/storage/redis.php:109
/libraries/joomla/cache/storage/redis.php:119
/libraries/joomla/cache/storage/redis.php:13
/libraries/joomla/cache/storage/redis.php:149
/libraries/joomla/form/field.php:1085
(also for consistency IMHO the same should be done in weblinks repository https://github.com/joomla-extensions/weblinks after)
@andrepereiradasilva are these not part of the platform? Shouldn't they be changed over there?
@andrepereiradasilva are these not part of the platform? Shouldn't they be changed over there?
no. afaik there is no plataform repository. there is a framework repository if that is what you mean, but those are in the vendor dir (see https://github.com/joomla/joomla-cms/tree/staging/libraries/vendor/joomla and https://github.com/joomla-framework/)
@andrepereiradasilva Oh, ok, I confused them. Thanks for clarifying. Will change those ones, too. Already made a PR to weblinks as you suggested.
Everything in libraries/joomla, libraries/cms and libraries/legacy should be updated too :)
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13156.
Conflicts resolved...
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13156.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13156.
Conflicts resolved...
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-20 00:40:22 |
| Closed_By | ⇒ | wilsonge |
| Milestone |
Added: |
||
On it...