[#13155] - [com_fields] - Creating a New field give SQL error on postgresql
- Fixed in Code Base
- 21 Dec 2016
- Medium
- Build: staging
- # 13155
- Diff
- alikon:patch-82
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13137 .
Summary of Changes
add a check for group_id
Testing Instructions
Create a new field see #13137 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields |
I would also put it into the XML and for safety, define the 0 as default value.
Ok I'll add the XML part
| Labels |
Added:
?
|
||
xml deafult added
Should the different installer scripts not be coherent to each other. In MySQL we default the value to 0 https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L643.
The issue is that PostgreSQL works differently (more strict) than MySQL. The default is defined as 0 in PostgreSQL as well (see https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L656) but we try to store an empty string there. MySQL just changes the invalid value to the default. PostgreSQL rightfully rejects it as an invalid value and throws an error.
At least we have this already fixed for j4 where mysql should be in strict mode ;)
I have tested this item
The error has gone. Thanks alikon!
Two things I noticed:
- the "field group" field in "articles field:edit" now shows 0 as default value
- a "field group" with assigned fields is not shown in "articles:edit"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13155.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13155.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-21 20:32:42 |
| Closed_By | ⇒ | zero-24 |
Merged thanks!
cpfeifer
-
We could also specify the option value as 0 in https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_fields/models/forms/field.xml#L31