[#13153] - Fix the calendar to work in the subform field
- Fixed in Code Base
- 14 Jan 2017
- Medium
- Build: staging
- # 13153
- Diff
- Fedik:calendar-in-subform
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This patch fix new calendar field to work in the subform field
Testing Instructions
Make sure that calendar field work in the subform
Example xml, can place in "Custom HTML" module xml (somwhere in params fieldset):
<field name="items" type="subform" multiple="true" label="Subform Field" >
<form>
<field name="something" type="calendar" label="Calendar" />
</form>
</field>Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have updated description a bit,
can place in "Custom HTML" module xml, somewhere in params fieldset
It works:
-
Before patch: We could not select a date from calendar form field in sub-form
-
After path: We can select a date from calendar
The only thing is the sub-form container looks too large (both before and after patch - unrelated to this PR), not sure if we have to care about it or not. If not, let me know and I will mark the test success
Put the XML code above to the file modules/mod_login/mod_login.xml after this line, https://github.com/joomla/joomla-cms/blob/staging/modules/mod_login/mod_login.xml#L130
Then edit the Login module, check that sub form field, make sure you can select date from the calendar
@joomdonation I did not touched the styling, in theory it should be the same as in other places
I have tested this item
It works:
-
Before patch: We could not select a date from calendar form field in sub-form
-
After path: We can select a date from calendar. Also, the standard calendar form field still works as before
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13153.
I have tested this item
Thanks for helping on instructions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13153.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13153.
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 20:17:23 |
| Closed_By | ⇒ | wilsonge |
Issue is still present when the subform is in the menu type xml file.
Testing Instructions
Put the XML code above to the file components/com_content/views/article/tmpl/default.xml after this line 35 - https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/article/tmpl/default.xml#L35
Then make a new menu item of type article, go to the options tab, add a new subform instance and click the calendar button
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13153.
Please open a new issue that contains a way to reproduce the problem on the last version. As this comment on a closed / merged issue will get lost soon. Thanks!
Thank you zero-24 and apologies. I am unfamiliar with the process as this is my 1st bug report on joomla.
New issue added - https://issues.joomla.org/tracker/joomla-cms/15842
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13153.
No need to apologies. I just want to be sure this does not get missed
can we have some test here? so the calendar field will be fully working in J3.7