Feeling Lucky
?
[#13141] - Coding style - PHP code tag and control structures
- Fixed in Code Base
- 11 Dec 2016
- Medium
- Build: staging
- # 13141
- Diff
- marcochirienti:staging-coding-style-2
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removed unnecessary white-spaces after the PHP code opening tag.
Added one white-space before the PHP code closing tag where missing.
Fixed style for control structures alternative syntax.
Testing Instructions
Code review.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_config com_contact com_content com_finder |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||
marcochirienti
- comment
- 9 Dec 2016
Hawk sight. Fixed.
Thanks @infograf768
| Category | Front End com_config com_contact com_content com_finder | ⇒ | Administration com_banners Front End com_config com_contact com_content com_finder |
shur
- comment
- 9 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13141.
zero-24
- comment
- 9 Dec 2016
Looks good from a quick review
jeckodevelopment
- comment
- 10 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13141.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 10 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13141.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-11 10:45:49 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on e2c70ee
Tested successfully by code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13141.