? Success

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
9 Dec 2016

Summary of Changes

While tags will be outputted in the layout, the authorised view levels will be loaded for each tag. With this patch it will be loaded only once

Testing Instructions

Just apply patch, tags should be displayed as before with a (I guess not noticeable) performance improvement

avatar bembelimen bembelimen - open - 9 Dec 2016
avatar bembelimen bembelimen - change - 9 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Dec 2016
Category Layout
avatar bembelimen bembelimen - change - 9 Dec 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 9 Dec 2016
Category Layout com_tags Layout
avatar laoneo
laoneo - comment - 9 Dec 2016

I have tested this item successfully on 69cb08f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.

avatar laoneo laoneo - test_item - 9 Dec 2016 - Tested successfully
avatar shur
shur - comment - 9 Dec 2016

@bembelimen - a small note:
Maybe you should not enter a new name ($authorisedViews) for this known value?
I think it is better to use one of the usual ($levels or $authorised) and already used in such situations in other files:
https://github.com/joomla/joomla-cms/search?utf8=%E2%9C%93&q=getAuthorisedViewLevels%28%29

avatar joomla-cms-bot joomla-cms-bot - change - 12 Dec 2016
Category Layout com_tags Layout
avatar bembelimen
bembelimen - comment - 12 Dec 2016

@shur Done, you can test now, thanks :)

avatar shur
shur - comment - 13 Dec 2016

I have tested this item successfully on e9fe9bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.

avatar shur shur - test_item - 13 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 13 Dec 2016

I have tested this item successfully on e9fe9bd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.

avatar laoneo laoneo - test_item - 13 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 13 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.

avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 460fc5c - 14 Dec 16
avatar rdeutz rdeutz - change - 14 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-14 20:05:35
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar rdeutz rdeutz - merge - 14 Dec 2016
avatar rdeutz rdeutz - close - 14 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment