[#13140] - Don't load authorised view levels in foreach for tags generation
- Fixed in Code Base
- 14 Dec 2016
- Medium
- Build: staging
- # 13140
- Diff
- bembelimen:Tag_Rendering
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
While tags will be outputted in the layout, the authorised view levels will be loaded for each tag. With this patch it will be loaded only once
Testing Instructions
Just apply patch, tags should be displayed as before with a (I guess not noticeable) performance improvement
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
brianteeman
- | Category | Layout | ⇒ | com_tags Layout |
@bembelimen - a small note:
Maybe you should not enter a new name ($authorisedViews) for this known value?
I think it is better to use one of the usual ($levels or $authorised) and already used in such situations in other files:
https://github.com/joomla/joomla-cms/search?utf8=%E2%9C%93&q=getAuthorisedViewLevels%28%29
| Category | Layout com_tags | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-14 20:05:35 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
I have tested this item✅ successfully on 69cb08f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13140.