? ? Success

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
5 Dec 2016

Pull Request for another PR #12839 - in order to separate into a few parts.

Summary of Changes

  • do not use $pdo = new PDO('sqlite::memory:'); directly, use getInstance() as in other places
  • remove notice "$this->connection is undefined" from sqlite driver when you try to re-connect() after disconnect();
  • add missing parent::tearDownAfterClass(); in JModelLegancyTest

Testing Instructions

Travis.
Code review.

Documentation Changes Required

N/A

avatar csthomas csthomas - open - 5 Dec 2016
avatar csthomas csthomas - change - 5 Dec 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Dec 2016
Category ⇒ Libraries Unit Tests
avatar csthomas csthomas - change - 7 Dec 2016
The description was changed
avatar csthomas csthomas - edited - 7 Dec 2016
avatar csthomas
csthomas - comment - 9 Dec 2016

@photodude Take a look at this PR.

avatar photodude
photodude - comment - 10 Dec 2016

I have tested this item ✅ successfully on 969747c

Successful test by code review.

This is an appropriate change for our unit tests


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.

avatar photodude photodude - test_item - 10 Dec 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 13 Dec 2016

I have tested this item ✅ successfully on 969747c

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.

avatar andrepereiradasilva andrepereiradasilva - test_item - 13 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Title
…
Unittest fix - do not use PDO driver directly
Unittest fix - do not use PDO driver directly
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Status Pending ⇒ Ready to Commit
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 13 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.

avatar jeckodevelopment jeckodevelopment - edited - 13 Dec 2016
avatar jeckodevelopment jeckodevelopment - change - 13 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 5824d76 - 13 Dec 16
avatar rdeutz rdeutz - merge - 13 Dec 2016
avatar rdeutz rdeutz - close - 13 Dec 2016
avatar rdeutz rdeutz - change - 13 Dec 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-12-13 12:22:37
Closed_By ⇒ rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 13 Dec 2016
avatar rdeutz rdeutz - merge - 13 Dec 2016
avatar cpfeifer cpfeifer - reference | fb3e6ba - 22 Dec 16

Add a Comment

Login with GitHub to post a comment