Feeling Lucky
?
?
[#13097] - Unittest fix - do not use PDO driver directly
- Fixed in Code Base
- 13 Dec 2016
- Medium
- Build: staging
- # 13097
- Diff
- csthomas:unittest_fix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone the build was successful Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for another PR #12839 - in order to separate into a few parts.
Summary of Changes
- do not use
$pdo = new PDO('sqlite::memory:');directly, usegetInstance()as in other places - remove notice "
$this->connectionis undefined" from sqlite driver when you try to re-connect()afterdisconnect(); - add missing
parent::tearDownAfterClass();inJModelLegancyTest
Testing Instructions
Travis.
Code review.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Unit Tests |
photodude
- comment
- 10 Dec 2016
I have tested this item
Successful test by code review.
This is an appropriate change for our unit tests
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.
andrepereiradasilva
- comment
- 13 Dec 2016
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.
| Title |
|
||||||
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
jeckodevelopment
- comment
- 13 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13097.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-13 12:22:37 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
@photodude Take a look at this PR.