[#13086] - Improve menu associations
- Fixed in Code Base
- 13 Dec 2016
- Medium
- Build: staging
- # 13086
- Diff
- bembelimen:patch-18
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
At the moment on a multilingual page if you have a menu item with language == All, the associations in mod_language links to the default menu item. With this patch, just the language changes and the user stays on the same page.
Testing Instructions
=> Create a multilingual page with at least two installed languages and association option active
=> Create a new menu item (e.g. login) and choose language = All
=> Active the language chooser module
=> Go to the new menu item
Before patch: the link for the second language goes to the "home" menu item
After patch: the link is the same as the current page, just the language changed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
@andrepereiradasilva
I think this bug is due to #10756
can you please check?
Fully agree
@bembelimen
please test #13112
| Category | Modules Front End | ⇒ | Front End Modules Multilanguage |
I have tested this item
as the alias issue is now solved and merged, this is now ok
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13086.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13086.
| Status | Pending | ⇒ | Ready to Commit |
RTC
thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13086.
jeckodevelopment
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-13 12:21:56 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
This may not work in some special conditions due to a bug in
ROOT/libraries/legacy/table/menu.phpwhere the alias of the menu item (in the root of that menu) set to ALL already exists in another language for a menu item at the root level of the menu displayed in that language.See https://github.com/joomla/joomla-cms/blob/staging/libraries/legacy/table/menu.php#L180-L188
On a multingual site, one can use the same alias for menu items in the root of their specific language as long as these menu items are tagged to the specific different languages, NOT including All.
i.e one can have
mysite.com/en/isaacnewtonandmysite,com/fr/isaacnewton.BUT, and here is the bug:
let's say you already have in fr-FR a menu item with the alias
isaacnewtontagged to fr-FR at the root of the menu.Create in an en-GB menu a menu item tagged to ALL with the same alias
isaacnewtonat the root of the menu.You can't save the menu item. All is good.
Now change the language to en-GB. It saves OK and that is fine.
Now, edit again the menu item and change its language to ALL: it is possible although it should NOT be!
Therefore with this patch when the menu item tagged to ALL is displayed and you click on the module to switch to French, instead of displaying the menu item tagged to ALL in the French interface, you get the original French menu item.
Conclusion: this patch is great but we should first solve the bug.