[#13085] - Improve new menu field
- Fixed in Code Base
- 6 Feb 2017
- Medium
- Build: staging
- # 13085
- Diff
- bembelimen:patch-16
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Improve parameter loading to have real default values.
Testing Instructions
It's a bit hard to test. You have to load the com_menus/models/fields/modal/menu.php field in your xml or took an existing one like: https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_menus/models/forms/item_alias.xml
After that you have to play with the parameters:
select="true"
new="true"
edit="true"
clear="true"
at the end all the old combinations should still work + if you remove this four parameters it should be the same as:
select="true"
new="false"
edit="false"
clear="true"
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
I have tested this item
Works like described
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13085.
@bembelimen i think this is the right approach, but IMHO we need to do the same for all modal fields. (article, newsfeed, contact, category, and weblink).
Also we should add some ACL check at least for core.create.
But of course this would be another PRs,
@andrepereiradasilva Yes, you're right, that would be the next step I think.
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13085.
Thanks @andrepereiradasilva
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-06 08:02:17 |
| Closed_By | ⇒ | rdeutz |
@andrepereiradasilva
The field was improved in #11916
can you have a look?