? Success

User tests: Successful: Unsuccessful:

avatar csthomas
csthomas
2 Dec 2016

Pull Request for Issue #12228.

Summary of Changes

Before patch the method return "1" or "0" or boolean value.

After patch always return boolean value.

Testing Instructions

Code review.

Documentation Changes Required

No

avatar csthomas csthomas - open - 2 Dec 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 Dec 2016

I have tested this item successfully on 55318d6

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13061.

avatar andrepereiradasilva andrepereiradasilva - test_item - 4 Dec 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 4 Dec 2016

I have tested this item successfully on 55318d6

Code review / also installed patch, and disabled com_banners


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13061.

avatar ggppdk ggppdk - test_item - 4 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 4 Dec 2016
Status New Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 4 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13061.

avatar jeckodevelopment jeckodevelopment - change - 4 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - reference | 6d5612c - 6 Dec 16
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - change - 6 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-06 22:29:00
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar joomla-cms-bot joomla-cms-bot - change - 6 Dec 2016
Category Libraries
avatar csthomas csthomas - head_ref_deleted - 6 Dec 2016

Add a Comment

Login with GitHub to post a comment