[#13060] - Protostar: missing some RTL code and order rtl classes load
- Closed
- 4 Jan 2018
- Medium
- Build: staging
- # 13060
- Diff
- infograf768:rtl_protostar
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR adds the class rtl on body when the language is RTL in order to use any .rtl .something .
It is added in component.php as well as error.php. Code is similar to index.php. It allows adding specific .rtl .something in the rtl.less files.
It also changes the order of loading of the .rtl .something present in the template_rtl.less when they are saved into template.css by generatecss.php.
This because these rtl classes should override their counterpart as set from various .less files when importing.
@mbabker
Thank you for checking
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
No opposition to that, but we could use these new notations only for new css as I guess changing the whole process would not be B/C.
@infograf768 can you resolve the conflicts with this PR please
Can you look at resolving the conflicts otherwise this will have to be closed @infograf768
Closed as the conflicts were not resolved after one year - it can always be reopened if updated
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-01-04 17:38:41 |
| Closed_By | ⇒ | brianteeman |
@brianteeman
PR redone #19328
why not use the html tag dir attribute for those rtl css overrides? https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/index.php#L127
Examples: