[#13043] - Multilingual Managers: htmlspecialchars needed
- Fixed in Code Base
- 29 Nov 2016
- Medium
- Build: staging
- # 13043
- Diff
- infograf768:assoc_htmlspecialchars
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Passing $item->title through htmlspecialchars()
Testing Instructions
Create a multilingual site (2 languages are enough).
Associate 2 articles.
Associate 2 categories.
Associate 2 menu items.
Associate 2 contacts.
Associate 2 newsfeeds.
For each of these add double quotes in the title of one of the items.
Example: mymenu "Useful", etc.
Display the managers for each kind of item
You will get stuff like this in the associations column (here the title is Poètes "français")
or for contact "en"
Patch, now you will correctly get:
and
same for the other components.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_menus com_newsfeeds |
I don't want to bother you, i just can't figure it out...
Why mixing JViewLegacy->escape() and htmlspecialchars()?
I've seen both being used throughout the CMS.
Is there a preference of one over the other inside html views?
Maybe this is not the right place for such a question. I know that it is not stricly related with the pull request. Anyway, where i should submit this kind of questions?
@marcochirienti https://groups.google.com/forum/#!forum/joomla-dev-general would be a proper place.
Since this here is about helpers and not views, JViewLegay->escape doesn't make sense anyway.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13043.
| Status | Pending | ⇒ | Ready to Commit |
RTC
zero-24
- | Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-29 08:20:09 |
| Closed_By | ⇒ | wilsonge |
I have tested this item✅ successfully on 671d36d
works as described. and solves the issue.
but i really think we should considere another PR shoulçd be done to transform this buttons in a unified layout.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13043.