[#13042] - [mod-menu] code style changes
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 13042
- Diff
- shur:patch-1
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Code style changes for mod_menu layout.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
don't understand why this change.
this makes always processing that param, even when not needed.
before this PR we have two request of $item->params->get('aliasoptions')
this makes always processing that param, even when not needed.
but perhaps you are right
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13042.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13042.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13042.
| Milestone |
Added: |
||
Do we really need a PR to remove an empty line and an opening and closing bracket?
YES
On 29 November 2016 at 21:46, Hannes Papenberg notifications@github.com
wrote:
Do we really need a PR to remove an empty line and an opening and closing
bracket?—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#13042 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8adE3nEzxbYK3xVD-PaCnuILOd-Eks5rDJ0ogaJpZM4K9l0R
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:28:02 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 608703e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13042.