? ? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
24 Nov 2016

Pull Request for Issue # .

Summary of Changes

Like #12993 but for tooltips.

Testing Instructions

Tooltips should still work normally.
Tooltips within a new row added in a subform should also work.

Documentation Changes Required

No.

avatar okonomiyaki3000 okonomiyaki3000 - open - 24 Nov 2016
avatar okonomiyaki3000 okonomiyaki3000 - change - 24 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2016
Category Libraries JavaScript
avatar okonomiyaki3000 okonomiyaki3000 - change - 24 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2016
Category Libraries JavaScript Libraries JavaScript Unit Tests
avatar Quy
Quy - comment - 23 Apr 2018

Can this be expanded to include popovers?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 23 Apr 2018

This was initially part of a big pr that took care of several of this kind of thing and I was asked to separate them. So, no, I would not like to include that here. I'll do a different PR for it. But, yes, the principle is exactly the same. Subforms fire an event called "subform-row-add" which anything that needs initialization should listen for.

avatar Quy Quy - test_item - 23 Apr 2018 - Tested successfully
avatar ReLater
ReLater - comment - 24 Apr 2018

3.8.8-dev
I have overwritten layouts/joomla/form/renderlabel.php to have tooltips instead of popovers for labels in a subform.

#JHtml::_('bootstrap.popover');
#$classes[] = 'hasPopover';

JHtml::_('bootstrap.tooltip');
$classes[] = 'hasTooltip';

The "problem" I have is that tooltips are initialized and displayed correctly in new rows also without this patch.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 24 Apr 2018

@ReLater Doesn't sound like much of a problem. Can you provide any more details? Where can I see your code?

avatar Quy
Quy - comment - 24 Apr 2018

I can confirm as ReLater. It is an issue with popover. I assume it was an issue with tooltip too when I tested this PR, but that was not the case.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 24 Apr 2018

@Quy What is an issue with popover? This PR has nothing to do with popover.

avatar Quy
Quy - comment - 24 Apr 2018

The subform uses popover and not tooltip. The issue is that popover is displayed as browser's tooltip. See above where ReLater had to change the code from popover to tooltip.

popover

avatar okonomiyaki3000
okonomiyaki3000 - comment - 24 Apr 2018

@Quy This PR has nothing to do with popover. I'll fix that in a different PR. This one is about tooltips. Yes, in fact tooltips already work even without this PR. There is a reason for that. When creating a new row in a subform, a function called fixScripts gets called which fixes a few limited things like this. In fact, it's the wrong way of handling it because it can only fix the things that subform knows about. The event-based solution is open ended and allows any new type of extension field to initialize itself instead of relying on subform.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 24 Apr 2018

Here is one for popovers #20222

avatar ReLater
ReLater - comment - 24 Apr 2018

I have tested this item successfully on 8ff6750


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12996.

avatar ReLater ReLater - test_item - 24 Apr 2018 - Tested successfully
avatar Quy Quy - change - 27 Apr 2018
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Apr 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12996.

avatar mbabker mbabker - change - 29 Apr 2018
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-04-29 14:51:34
Closed_By mbabker
Labels Added: ?
avatar mbabker mbabker - close - 29 Apr 2018
avatar mbabker mbabker - merge - 29 Apr 2018

Add a Comment

Login with GitHub to post a comment