User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Like #12993 but for tooltips.
Tooltips should still work normally.
Tooltips within a new row added in a subform should also work.
No.
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries JavaScript |
Labels |
Added:
?
|
Category | Libraries JavaScript | ⇒ | Libraries JavaScript Unit Tests |
This was initially part of a big pr that took care of several of this kind of thing and I was asked to separate them. So, no, I would not like to include that here. I'll do a different PR for it. But, yes, the principle is exactly the same. Subforms fire an event called "subform-row-add"
which anything that needs initialization should listen for.
3.8.8-dev
I have overwritten layouts/joomla/form/renderlabel.php to have tooltips instead of popovers for labels in a subform.
#JHtml::_('bootstrap.popover');
#$classes[] = 'hasPopover';
JHtml::_('bootstrap.tooltip');
$classes[] = 'hasTooltip';
The "problem" I have is that tooltips are initialized and displayed correctly in new rows also without this patch.
I can confirm as ReLater. It is an issue with popover. I assume it was an issue with tooltip too when I tested this PR, but that was not the case.
@Quy This PR has nothing to do with popover. I'll fix that in a different PR. This one is about tooltips. Yes, in fact tooltips already work even without this PR. There is a reason for that. When creating a new row in a subform, a function called fixScripts
gets called which fixes a few limited things like this. In fact, it's the wrong way of handling it because it can only fix the things that subform knows about. The event-based solution is open ended and allows any new type of extension field to initialize itself instead of relying on subform.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-04-29 14:51:34 |
Closed_By | ⇒ | mbabker | |
Labels |
Added:
?
|
Can this be expanded to include popovers?