[#12994] - Fix minicolor initialization in subforms. etc.
- Fixed in Code Base
- 2 Aug 2018
- Medium
- Build: staging
- # 12994
- Diff
- okonomiyaki3000:fix-subform-minicolors
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Similar to #12542 and #12993 but for the minicolors color picker.
Testing Instructions
First of all, color pickers should still work normally. More importantly, color pickers inside of subforms should be initialized when new rows are added.
Documentation Changes Required
No
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout JavaScript |
These js failures are related to combobox, probably nothing to do with this PR.
Just checking if media/system/js/subform-repeatable-uncompressed.js should be updated since media/system/js/subform-repeatable.js was updated?
Could you please provide more specific test instructions (eg. were do i use the color-picker?).
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12994.
I have tested this item
I have tested successfully
Test
Components => Banners => New => MultilineText TextColor Picker
Result
It worked
@icampus
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12994.
I have tested this item
Reproduction steps:
I installed the componentbuilder which already has subforms included (example url: index.php?option=com_componentbuilder&view=component_admin_views&ref=joomla_components&layout=edit&id=27).
After that I replaced one field from a row with a color picker, added and removed some rows and the color pickers are initialized right.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12994.
| Status | Pending | ⇒ | Ready to Commit |
Ready to Commit after two successful tests.
@okonomiyaki3000 Please resolve conflicting Files.
| Labels |
Added:
?
|
||
There is no problem here. Do not believe Appveyor's lies.
mbabker
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-02 22:35:01 |
| Closed_By | ⇒ | mbabker |
I have tested this item✅ successfully on 29d47a1
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12994.