[#12973] - [com_finder] review config global default options
- Fixed in Code Base
- 6 Jun 2017
- Medium
- Build: staging
- # 12973
- Diff
- andrepereiradasilva:patch-33
- Success hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR intends to normalize config global default options in com_finder.
The method used was:
- Review cs of the config.xml file - also add missing default values
- Check the current params in installation joomla.sql mysql
- Add missing defaults to install sql
Testing Instructions
- Code review
- Apply patch and #12916 patch (if not merged yet)
- Delete configuration.php
- Install Joomla (no sample)
- Create a menu item of "Smart Search" type and check all "Use Global"have the global value.
Documentation Changes Required
None.
Added/changed defaults in the xml
changed: none
added:
- opensearch_name, opensearch_description: empty
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder SQL Installation Postgresql MS SQL |
| Easy | No | ⇒ | Yes |
Still got some missing global values
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12973.
@brianteeman IIRC those 3 don't have a global value in com_finder, so you can't use global. don't have any idea where the use global is fetched (if it's fetched from somewhere)
If they dont have a global value then why do they have a use global setting? Is that another bug?
probably .. no time to investigate now what value is read in php
If they dont have a global value then why do they have a use global setting? Is that another bug?
didn't find any references to that in com_finder ( except the xml - https://github.com/joomla/joomla-cms/blob/staging/components/com_finder/views/search/tmpl/default.xml#L100-L133 ), but in other components those parameters exist and are used.
maybe @chrisdavenport knows if they are used or not, and why they don't have a global value like the others.
anyway this PR cannot fix a global value that seems to not exist...
They don't have the "show_global" feature turned on anyway, so this PR should be tested without those three options.
I'd say it is a copy paste error and those parameter global options should be removed.
ok. so ready to test
I think the global values should exist and should be supported in the core layout. Don't know why they were missed. But, I agree, fixing that should be a different PR.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12973.
| Easy | Yes | ⇒ | No |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12973.
| Status | Pending | ⇒ | Ready to Commit |
RTC after two successful tests but Conflicts are to resolve.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-06-06 18:54:28 |
| Closed_By | ⇒ | rdeutz |
I have tested this item? unsuccessfully on 66363b9
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12973.