[#12966] - Properly use sublayout
- Fixed in Code Base
- 4 Jan 2017
- Medium
- Build: staging
- # 12966
- Diff
- okonomiyaki3000:properly-use-sublayout
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
A few cases where layouts were calling JLayoutHelper::render when they could have been calling $this->sublayout instead have been changed. The main benefit of this is that it makes it easier to override parts of a layout.
Testing Instructions
Check that the layouts are still rendering as expected.
The content.info_block layout appears at the top of article pages (and others) on the site.
The searchtools.default layout renders the search tools at the top of list pages in the administrator.
The editors.buttons layout renders the buttons that appear below the editor (for example, when editing an article).
Documentation Changes Required
Probably not.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Layout |
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12966.
@okonomiyaki3000 can you please look at the conflicting file?
@jeckodevelopment @anibalsanchez @okonomiyaki3000 @RonakParmar please retest. I have just fixed the merge conflicts.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12966.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12966.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12966.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-04 19:01:54 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on 1254df0
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12966.