? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
22 Nov 2016

Summary of Changes

This PR intends to normalize onfig global default options in com_joomlaupdate.

The method used was:

  1. Review cs of the config.xml file - also add missing default values
  2. Check the current params in installation joomla.sql mysql
  3. Add missing defaults to install sql

Testing Instructions

  1. Code review

Documentation Changes Required

None.

Added/Changed defaults in the xml

none. just added the sql part

avatar andrepereiradasilva andrepereiradasilva - open - 22 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 22 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Nov 2016
Category Administration com_joomlaupdate SQL Installation Postgresql MS SQL
avatar brianteeman
brianteeman - comment - 5 Dec 2016

I have tested this item successfully on f25b192

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12965.

avatar brianteeman brianteeman - test_item - 5 Dec 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 5 Dec 2016

I have tested this item successfully on f25b192


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12965.

avatar jeckodevelopment jeckodevelopment - test_item - 5 Dec 2016 - Tested successfully
avatar brianteeman brianteeman - change - 6 Dec 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 6 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12965.

avatar brianteeman brianteeman - change - 6 Dec 2016
Milestone Added:
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Dec 2016

just fixed conflicts no need to retest

avatar wilsonge
wilsonge - comment - 9 Dec 2016

Sorry merging Brian's PR earlier has caused more conflicts :(

avatar zero-24
zero-24 - comment - 21 Dec 2016

Please fix the conflicts. I'm removing RTC until that ?

avatar zero-24 zero-24 - change - 21 Dec 2016
Status Ready to Commit Pending
Labels Removed: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Jan 2017

@zero-24 fixed conflicts

avatar zero-24 zero-24 - change - 3 Jan 2017
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2017-01-03 15:53:18
Closed_By zero-24
avatar zero-24 zero-24 - close - 3 Jan 2017
avatar zero-24 zero-24 - merge - 3 Jan 2017
avatar zero-24
zero-24 - comment - 3 Jan 2017

Thanks ?

Add a Comment

Login with GitHub to post a comment