? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Nov 2016

Summary of Changes

This PR intends to normalize onfig global default options in com_banners.

The method used was:

  1. Review cs of the config.xml file - also add missing default values
  2. Check the current params in installation joomla.sql mysql
  3. Add missing defaults to install sql

Testing Instructions

  1. Code review

Documentation Changes Required

None.

Added/Changed defaults in the xml

changed:

  • purchase_type: 1 (was 0 that didn't exist in list options)
  • history_limit: 10 (was 5, to normalise with other components)

added:

  • metakey_prefix: empty
avatar andrepereiradasilva andrepereiradasilva - open - 21 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2016
Category Administration com_banners Postgresql SQL Installation MS SQL
avatar brianteeman
brianteeman - comment - 5 Dec 2016

I have tested this item successfully on 7fd17b4

On code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.

avatar brianteeman brianteeman - test_item - 5 Dec 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 5 Dec 2016

I have tested this item successfully on 7fd17b4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.

avatar jeckodevelopment jeckodevelopment - test_item - 5 Dec 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 5 Dec 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 5 Dec 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.

avatar jeckodevelopment jeckodevelopment - change - 5 Dec 2016
Milestone Added:
avatar rdeutz rdeutz - change - 6 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-06 22:18:21
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - reference | 3667d6b - 6 Dec 16
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - close - 6 Dec 2016

Add a Comment

Login with GitHub to post a comment