Feeling Lucky
?
[#12963] - [com_banners] review config global default options
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 12963
- Diff
- andrepereiradasilva:defaults-com_banners
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR intends to normalize onfig global default options in com_banners.
The method used was:
- Review cs of the config.xml file - also add missing default values
- Check the current params in installation joomla.sql mysql
- Add missing defaults to install sql
Testing Instructions
- Code review
Documentation Changes Required
None.
Added/Changed defaults in the xml
changed:
- purchase_type: 1 (was 0 that didn't exist in list options)
- history_limit: 10 (was 5, to normalise with other components)
added:
- metakey_prefix: empty
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners Postgresql SQL Installation MS SQL |
jeckodevelopment
- comment
- 5 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 5 Dec 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:18:21 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 7fd17b4
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.