?
Success
-
Success
continuous-integration/drone
the build was successful
Details
-
Success
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
-
Success
JTracker/HumanTestResults
Human Test Results: 2 Successful 0 Failed.
Details
User tests:
Successful:
Unsuccessful:
Summary of Changes
This PR intends to normalize onfig global default options in com_banners.
The method used was:
- Review cs of the config.xml file - also add missing default values
- Check the current params in installation joomla.sql mysql
- Add missing defaults to install sql
Testing Instructions
- Code review
Documentation Changes Required
None.
Added/Changed defaults in the xml
changed:
- purchase_type: 1 (was 0 that didn't exist in list options)
- history_limit: 10 (was 5, to normalise with other components)
added:
andrepereiradasilva
-
open
-
21 Nov 2016
andrepereiradasilva
-
change
-
21 Nov 2016
joomla-cms-bot
-
change
-
21 Nov 2016
Category |
|
⇒ |
Administration
com_banners
Postgresql
SQL
Installation
MS SQL
|
brianteeman
-
test_item
-
5 Dec 2016
-
Tested successfully
jeckodevelopment
-
test_item
-
5 Dec 2016
-
Tested successfully
jeckodevelopment
-
change
-
5 Dec 2016
Status |
Pending |
⇒ |
Ready to Commit |
jeckodevelopment
-
change
-
5 Dec 2016
Status |
Ready to Commit |
⇒ |
Fixed in Code Base |
Closed_Date |
0000-00-00 00:00:00 |
⇒ |
2016-12-06 22:18:21 |
Closed_By |
|
⇒ |
rdeutz |
rdeutz
-
close
-
6 Dec 2016
rdeutz
-
merge
-
6 Dec 2016
rdeutz
-
merge
-
6 Dec 2016
rdeutz
-
close
-
6 Dec 2016
Add a Comment
Login with GitHub to post a comment
I have tested this item✅ successfully on 7fd17b4
On code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12963.