Thank you so much for doing this!!!

I said I would do it but I'e been massively bogged down with some client
work. It sounds like your methodology is very similar to the one that I had
planned although I suspect yours is better

On 21 November 2016 at 19:41, andrepereiradasilva notifications@github.com
wrote:

Summary of Changes

During the PR that added the "Use Global (xxxxx)" several inconsistencies
with install sql default options and configs xml default options were
detected.

This PR intends to normalize them in com_content.

The method used was:

1. Review cs of the com_content config.xml file
2. Check the current com_content installation params in installation joomla.sql mysql
3. Check the differences with the default files in the xml (the sql default values having priority)
4. Update the config.xml default values according
5. Delete the current params from the db and save the new ones by reloading and saving the options.
6. Use the saved json params here

Testing Instructions

1. Apply patch
2. Delete configuration.php
3. Install Joomla (no sample)
4. Create an article and check all "Use Global" have the global value.

Documentation Changes Required

None.

You can view, comment on, or merge this pull request online at:

#12962
Commit Summary

• review com_content config options
• mysql
• postgresql
• sqlazure
• Update joomla.sql
• Update joomla.sql
• Update joomla.sql

File Changes

• M administrator/components/com_content/config.xml https://github.com/joomla/joomla-cms/pull/12962/files#diff-0 (760)
• M installation/sql/mysql/joomla.sql https://github.com/joomla/joomla-cms/pull/12962/files#diff-1 (2)
• M installation/sql/postgresql/joomla.sql https://github.com/joomla/joomla-cms/pull/12962/files#diff-2 (2)
• M installation/sql/sqlazure/joomla.sql https://github.com/joomla/joomla-cms/pull/12962/files#diff-3 (2)

Patch Links:

• https://github.com/joomla/joomla-cms/pull/12962.patch
• https://github.com/joomla/joomla-cms/pull/12962.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12962, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ShIgvSalLIbCjNRrlvNmeeRWcXVks5rAfPigaJpZM4K4nBy
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

ok. let's hope this gets tests so we don't get conflict in any change of the xml

also there A LOT of components this is needed ?

Keep in mind that the default values in the XML have to match the default values used in PHP code for B/C reasons. If they are different, adjust the XML one but never adjust the PHP one or you change behavior (you can do that with 4.0).
The SQL ones actually are allowed to be different. They only apply for new installations and thus we have no B/C issues here.

ok so we have $params->get('save_history', 0) (changed to 1) this means the default save_history needs to be 0 in the config.xml?
Found also:

• $this->params->get('show_category_title', 1) (changed to 0)
• $this->params->get('show_description', 1) (changed to 0)
• $this->params->get('show_cat_num_articles', 1) (changed to 0)

So @Bakual what do you propose? The opposite? Use the config default and change the sql with those values?

ok so we have $params->get('save_history', 0) (changed to 1) this means the default save_history needs to be 0 in the config.xml?

That needs to stay as 0 in the XML. It's this way since we didn't want to enable versioning for updating users when it was introduced, but for new installs we enable it by default.

The others seems to be inconsistent currently even in code. I don't know the reason there (if there even is one). You need to take the current PHP behaviour and make the XML fit it. Reason for that is that there may be cases that there is no saved value for the param and you don't want to change the behaviour magically if the user just opens and saves the options without changing anything.

As said, the SQL files don't have to match the XML and PHP ones. Just the XML and PHP have to match and there the PHP takes precende and the XML has to follow it. There are valid reasons for the SQL one to be different.
For the "Use Global" feature, it's just important that there is a saved value (the SQL one). It doesn't matter at all which value that is. Just take a sensible default value.

ok i guess i will have to review this again.

ok reviewed. should be fine now. also updated PR description

@andrepereiradasilva

are these Steps of "Testing Instructions" correct for this PR and #12970 #12973 #12979:

1. Install Joomla (no sample)
2. Delete configuration.php
3. Apply patch
4. Create an article and check all "Use Global" have the global value. (resp. contact, finder, tags)

@andrepereiradasilva Could you fix the merge conflicts so we can test this? Thanks.

If this Issue get no Response, it will be closed at 22th September 2018.

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/12962

This has been closed due to lack of response to the requests above – it can always be reopened.