[#1296] - Correct @font-face declaration for IE6-8
- Closed
- 27 Dec 2014
- Medium
- Build: master
- # 1296
- Diff
- JustPlainHigh:patch-2
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
I have been testing Icomoons on IE6-8. This separate @font-face declaration is required for Icomoons to work on IE8. With the corrected Icomoon lte IE7 js file and this LESS correction, Icomoons now works in IE6-8.
Will do :)
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | External Library |
Is this issue still current? In case it is, could you please update your branch to the latest staging? Otherwise please close it. I would also ask if we are even still supporting IE6-8. I personally would drop it.
We support IE8+. See http://docs.joomla.org/Joomla_Browser_Support.
As for dropping it. Looking at http://www.netmarketshare.com/ and their report "Desktop Share by Version", it still is at 17%. I have no clue how accurate that site is. But I know that we only switched recently from IE8 to IE10 in our company.
It's the most current version for Windows XP and the default one for Windows 7. That explains why it's such wide spread, especially in corporate enviroments.
So dropping it is not an option at all.
| Status | Pending | ⇒ | Closed |
As per comment in staging file:
https://github.com/joomla/joomla-cms/blob/staging/media/jui/less/icomoon.less#L1-13
Due to a bug in the compiler that doesn't handle the relative paths correctly, the @font-face stuff needs to go in the templates less files
Fixed here: https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/less/icomoon.less
Closing. Please open a new Issue if the Problem still exists.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/1296.
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/1296
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-27 15:06:56 |
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.