[#1295] - Correct icon-lock and regexp
- Closed
- 27 Dec 2014
- Medium
- Build: master
- # 1295
- Diff
- JustPlainHigh:patch-1
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
I have been testing on IE6/7 and discovered that the js fix does not work. This is as a result of "icon-locked" instead of "icon-lock" and an incorrect regexp pattern (returns "undefined" in icons - the world's least helpful error message).
Still to confirm all "icon-" variations. Otherwise testing works in IE6 and IE7 (with @font-face correction to Icomoon.less). Will submit icomoon.less correction via pull request.
High-Priestess-of-The-Technology
- 
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | External Library |
Is this issue still current? In case it is, please update your branch to the latest staging. In case its not, please close this PR.
Besides: Do we even support IE6-8?
We support IE 8+: http://docs.joomla.org/Joomla_Browser_Support
| Status | Pending | ⇒ | Closed |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/1295
Closing as allready fixed in staging:
icon-lock / icon-locked
https://github.com/joomla/joomla-cms/blob/staging/media/jui/js/icomoon-lte-ie7.js#L231-232
and
c = c.match(/icon-[^\s'"]+/);
https://github.com/joomla/joomla-cms/blob/staging/media/jui/js/icomoon-lte-ie7.js#L313
Thanks for your contribution @High-Priestess-of-The-Technology
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/1295.
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-27 14:54:54 |
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.