Feeling Lucky
?
[#12929] - [JHtmlNumber::bytes] Format number according to language
- Fixed in Code Base
- 18 Nov 2016
- Medium
- Build: staging
- # 12929
- Diff
- andrepereiradasilva:patch-25
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
As discussed in joomla/joomla-websites#765 JHtmlNumber::bytes() is returning the number format always in english format.
This PR makes it return the format in the current language, using the languages packs DECIMALS_SEPARATOR and THOUSANDS_SEPARATOR variables for formatting the number.
Testing Instructions
- Use a multilingual site with some languages (example: pt-PT) and apply patch
- Add to protostar index.php the following code
echo JHtmlNumber::bytes(1).'<br/>';
echo JHtmlNumber::bytes(1024).'<br/>';
echo JHtmlNumber::bytes(1024*1024).'<br/>';
echo JHtmlNumber::bytes(1024*1024*1024).'<br/>';
echo JHtmlNumber::bytes(1024*1024*1024*1024).'<br/>';- Go to site and check if the number format is correct in all the languages you installed (you can check if respect the language variables in
/language/xx-XX/xx-XX.inifile).
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Category | Libraries | ⇒ | Libraries Unit Tests |
| Labels |
Added:
?
|
||
| Labels |
Removed:
?
|
||
infograf768
- comment
- 18 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12929.
| Milestone |
Added: |
||
zero-24
- comment
- 18 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12929.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
zero-24
- comment
- 18 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12929.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-18 16:28:13 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
wilsonge
- comment
- 18 Nov 2016
Thanks :)
In English I get:
1.00 b
1.00 kB
1.00 MB
1.00 GB
1.00 TB
and in French
1,00 b
1,00 kB
1,00 MB
1,00 GB
1,00 TB
When I changed the echo to
echo JHtmlNumber::bytes(1000*1024*1024*1024*1024).'<br/>';I got
1 000,00 TB
Which is indeed correct in French.