[#12928] - Set session object's _state to 'inactive' when session is closed
- Fixed in Code Base
- 18 Nov 2016
- Medium
- Build: staging
- # 12928
- Diff
- chrBrd:sessionPatch
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Currently, if a session is closed (not destroyed) the session object's _state property remains set as 'active'. Consequently, using the session object's start() method will result in it returning before it can do anything.
As a session has been ended by the server once the close() method has been called the object's _state property should possibly be set to 'inactive'.
Summary of Changes
Amended JSession class' close() method to set session object's _state property to 'inactive' after a session is ended by the server.
Testing Instructions
- Apply patch.
- Wait for a session to start.
- Close it using
close(); - The session object's
_stateproperty will be set to 'inactive' once the handler'ssave()method has been executed and the server has ended the session.
Documentation Changes Required
None
Note
In my testing before implementing this I couldn't see any good reason for a session object's state to remain 'active' once the actual session's been ended by the server; I accept there may well be one I overlooked.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-18 17:07:10 |
| Closed_By | ⇒ | wilsonge |
This is the kinda change which is going to cause all kinds of people all kinds of issues I'm sure. But it looks clearly correct to me so I'm going to bite the bullet and merge on review