? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Nov 2016

#11157 introduces a new thing called setupCallbacString

The OCD typo hunter in me spotted the missing k so I have changed all instances to setupCallbackString

There is no b/c issue as #11157 was only introduce by @fedik in 3.7 so the code hs never been released

I'm afraid I have no idea how to test it other than by code review as I dont know what it does

b1e396e 16 Nov 2016 avatar brianteeman typo
avatar brianteeman brianteeman - open - 16 Nov 2016
avatar brianteeman brianteeman - change - 16 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2016
Category JavaScript Front End Plugins
avatar zero-24 zero-24 - change - 16 Nov 2016
Labels Added: ?
avatar zero-24 zero-24 - change - 16 Nov 2016
Milestone Added:
avatar zero-24 zero-24 - change - 16 Nov 2016
Milestone Removed:
avatar zero-24 zero-24 - change - 16 Nov 2016
Milestone Added:
avatar Fedik
Fedik - comment - 16 Nov 2016

I have no idea how to test it

all xtd-buttons should continue to work ?

avatar dgt41
dgt41 - comment - 16 Nov 2016

@brianteeman since you did the correction both php and javascript this only needs a review

avatar jeckodevelopment
jeckodevelopment - comment - 16 Nov 2016

I have tested this item successfully on b1e396e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12913.

avatar jeckodevelopment jeckodevelopment - test_item - 16 Nov 2016 - Tested successfully
avatar dgt41 dgt41 - test_item - 16 Nov 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 16 Nov 2016

I have tested this item successfully on b1e396e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12913.

avatar dgt41 dgt41 - change - 16 Nov 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 16 Nov 2016

RTC

avatar rdeutz rdeutz - close - 16 Nov 2016
avatar rdeutz rdeutz - merge - 16 Nov 2016
avatar rdeutz rdeutz - reference | b632863 - 16 Nov 16
avatar rdeutz rdeutz - merge - 16 Nov 2016
avatar rdeutz rdeutz - close - 16 Nov 2016
avatar rdeutz rdeutz - change - 16 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-16 19:28:47
Closed_By rdeutz
avatar brianteeman
brianteeman - comment - 16 Nov 2016

Thanks

avatar brianteeman brianteeman - head_ref_deleted - 16 Nov 2016

Add a Comment

Login with GitHub to post a comment