[#12877] - Disable Chosen.js for the rule field, again
- Fixed in Code Base
- 10 Dec 2016
- Medium
- Build: staging
- # 12877
- Diff
- Fedik:chosen-disable-for-rulefield
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12843 .
Summary of Changes
Revert the check for instance type of data-chosen, to allow to disable Chosen for field with data-chosen="true"
Testing Instructions
Make sure that the rule field use simple <select> input (without Chosen stylling),
and all icons "ok/loading/error" are visible again when try to change the rule value
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12877.
| Status | Pending | ⇒ | Ready to Commit |
RTC
NOTE to whomever merge this: please ping me!
Is the only way to achieve this really with more hacks to chosen :(
unfortunately,
Correct way would be apply Chosen only to "specific" <select> with specific class, eg "advancedSelect", instead of apply Chosen to all <select> on the page,
but for now it sounds like utopia
zero-24
- | Milestone |
Added: |
||
seems comment are the common practice, could you them please add the reason why this change was made, thanks
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-10 09:39:48 |
| Closed_By | ⇒ | rdeutz |
cpfeifer
-
I have tested this item✅ successfully on c4fe40a
After patch is applied and browser cache cleared chosen is gone from ACL rule selects and icons are back.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12877.