[#12874] - Put back Loading/ok/error images while changing permission [solve regression]
- Closed
- 14 Jan 2017
- Medium
- Build: staging
- # 12874
- Diff
- andrepereiradasilva:permissions
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 1 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12843.
Summary of Changes
In conjunction with #12855 (that takes care of the search in the permissions select box), this PR corrects the CSS so the ok/error/loading image is shown again as in 3.6.4.
Testing Instructions
Very simple test. Just CSS change.
- Go to any permissions tab and change any permission. You will notice there is no image showing loading/success/error.
- Apply patch and clear browser cache
- Go to any permissions tab and change any permission, you will now the image appears now and also the width of the columns stay stable (this is an improvement comparing to 3.6.4).
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
@microtribe
You have to clear cache after patching
@andrepereiradasilva
Works here for LTR languages. Not for RTL
You also have to override in template-rtl.less
with
/* Permissions */
#permissions-sliders span[id^="icon_"] {
margin-right: 120px;
width: 16px;
display: inline-block;
margin-left: 0;
}and run generatecss.php
@andrepereiradasilva an you update for RTL please and then we can get this tested and merged
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12874.
| Status | Pending | ⇒ | Information Required |
@brianteeman @infograf768 should work on rtl now too. (don't forget to clean browser cache on test)
I have tested this item
with or without PR image appears after change permission.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12874.
I have tested this item
This PR doesn't seems to be needed anymore in the latest staging. Before applying the patch the icons are already shown when changing the permissions.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12874.
closed as seems there is no use for this since chosen was removed from this fields.
If/when chosen is readded this is waht will be needed
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-14 13:35:30 |
| Closed_By | ⇒ | andrepereiradasilva |
I have tested this item? unsuccessfully on 8a39724
Went to an article, changed permissions, confirmed no loading/success/error image displayed. Applied patch through Patch Tester. Went to an article, changed permissions, still no loading/success/error image displayed.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12874.