? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Nov 2016

Summary of Changes

Removes the default value from the feed_character_count parameter in newsfeed form and menu item.
Adds the "Show Global Value" feature to those two fields
This allows to leave the field empty and thus use the value from the component configuration.

Testing Instructions

  1. Create a newsfeed
  2. Create a menu item for that newsfeed
  3. Play around with the "Characters Count" parameter and make sure it works as expected. If the field is empty, it should show a hint with the value from the component configuration.

Documentation Changes Required

None

avatar Bakual Bakual - open - 11 Nov 2016
avatar Bakual Bakual - change - 11 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category Administration com_newsfeeds Front End
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Nov 2016

works on news feed edit and news feed menu item type, but not working properly in "List All News Feed Categories" and "List News Feeds in a Category" menu item types

avatar Bakual
Bakual - comment - 12 Nov 2016

I have no clue why I missed those two. Done now. ?

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Nov 2016

I have tested this item successfully on 622b55e

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12869.

avatar brianteeman
brianteeman - comment - 15 Nov 2016

I have tested this item successfully on 622b55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12869.

avatar brianteeman brianteeman - test_item - 15 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2016

RTC?

avatar brianteeman
brianteeman - comment - 16 Nov 2016

I am sure tobias will do that when he gets online (I shouldnt do it as I was a tester - but i sometimes forget that rule)

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2016

sure, just pinging in case someone forgot

avatar brianteeman
brianteeman - comment - 16 Nov 2016

I know that @zero-24 and I both run the Two Tests check on the issue tracker multiple times a day - we dont need to be pinged unless its been a few days in which case we have missed it

avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2016

ok ok

avatar zero-24 zero-24 - change - 16 Nov 2016
Milestone Added:
avatar zero-24 zero-24 - change - 16 Nov 2016
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar zero-24 zero-24 - change - 16 Nov 2016
Labels
avatar rdeutz rdeutz - change - 16 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-16 19:30:15
Closed_By rdeutz
avatar rdeutz rdeutz - close - 16 Nov 2016
avatar rdeutz rdeutz - merge - 16 Nov 2016
avatar rdeutz rdeutz - reference | b47891f - 16 Nov 16
avatar rdeutz rdeutz - merge - 16 Nov 2016
avatar rdeutz rdeutz - close - 16 Nov 2016
avatar Bakual Bakual - head_ref_deleted - 16 Nov 2016

Add a Comment

Login with GitHub to post a comment