[#12868] - Adding a "Use Global" option to tag list menu item
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12868
- Diff
- Bakual:AddGlobalOptionTagListLimit
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone the build was successful Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Currently, the "Compact List of tagged items" menu item type has a parameter called "# Items to List". It specifies the list limit.
In the tag model, the code is there to fall back to the list_limit value from the global configuration (see https://github.com/joomla/joomla-cms/blob/staging/components/com_tags/models/tag.php#L213), however there is no option in the menu item which would allow that fallback.
This PR adds this option and removes the default value (otherwise you can't use the "Use Global" option).
Note: It's not possible to show the value from the global configuration since the parameter is named differently. In com_tags it is named display_num and the global one list_limit. We would have to renamed the parameter in com_tags to make it work, but that isn't B/C. Thus it's not possible.
Testing Instructions
Create a menu item of that type and make sure that parameter works as expected together with the List Limit parameter from the global configuration.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Front End |
We could do something like this, but usually we don't mess with user settings.
Honestly I don't think it is important enough to make an exception and it can wait for 4.0 to change that.
agree can wait but it would be good to make a PR to 4.0 branch so we don't forget that wrong parameter.
Or in alternative we can add a new attribute useglobal_fieldname="list_limit" for those cases to be easy to identify later and would process right them now.
BTW why didn't you use useglobal="true" here?
Followed the instruction and tried this several times with NO success.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12868.
Or in alternative we can add a new attribute useglobal_fieldname="list_limit" for those cases to be easy to identify later and would process right them now.
In core, it was only that one parameter as far as I saw. I don't think it makes sense to add special code for that. Once this is merged, I can do a PR for the 4.0 branch.
Followed the instruction and tried this several times with NO success.
@mehranfazili Can you be more specific in what you tried that didn't work?
Did the "Use Global" option not appear? Or did it not behave as expected?
I have tested this item
as talked above
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12868.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12868.
| Category | com_tags Front End | ⇒ | com_tags Front End Language & Strings |
| Labels |
Added:
?
|
||
| Category | com_tags Front End Language & Strings | ⇒ | com_tags Front End |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12868.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12868.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:50:03 |
| Closed_By | ⇒ | rdeutz |
one question: can we replace the parameter and add an update query?
it would be something like this for mysql
or something like this needs to go to 4.0?