? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Nov 2016

This PR expands the already merged #11911 to com_tags

Summary of Changes

Enables the new "Show Global Value" feature for all tag menu item types.

Testing Instructions

Test the tag menu items. All list elements with a "Use Global" entry should show the global value like this:
tagoption

Exception: The robots field will not show the global value.

Note: If you get a message that some global values can't be found, try saving the component options.

Another note: The parameters Show Heading Image and Tag Descriptions currently have a "Use Global" option, but that one is useless since the component settings don't have that field. So there is no global value to be used. I left it like this as it is out of scope of this PR and I don't know if we should remove the option or add the field to the component options.

Documentation Changes Required

None

avatar Bakual Bakual - open - 11 Nov 2016
avatar Bakual Bakual - change - 11 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category com_tags Front End
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

notice this two in tags menu items

image
image

avatar Bakual
Bakual - comment - 11 Nov 2016

The "Items to List" (display_num) doesn't have a global value option currently. We could add code to take the one from the global configuration but that is beyond this PR.

I have added the "Maximum Characters".

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

The "Items to List" (display_num) doesn't have a global value option currently. We could add code to take the one from the global configuration but that is beyond this PR.

ok for another PR so the options be consistent

avatar andrepereiradasilva andrepereiradasilva - test_item - 11 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

I have tested this item successfully on 98a9f70

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12865.

avatar Bakual
Bakual - comment - 11 Nov 2016

@andrepereiradasilva I had a look at the display_num issue. See #12868. Unfortunately the lookup isn't possible here due to badly named parameters.

avatar brianteeman brianteeman - test_item - 14 Nov 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 14 Nov 2016

I have tested this item successfully on 98a9f70


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12865.

avatar jeckodevelopment
jeckodevelopment - comment - 15 Nov 2016

I have tested this item successfully on 98a9f70


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12865.

avatar jeckodevelopment jeckodevelopment - test_item - 15 Nov 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 15 Nov 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 15 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12865.

avatar jeckodevelopment jeckodevelopment - change - 15 Nov 2016
Milestone Added:
avatar jeckodevelopment jeckodevelopment - change - 15 Nov 2016
Labels Added: ?
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - reference | 48ba63d - 15 Nov 16
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 21:49:29
Closed_By rdeutz
avatar Bakual Bakual - head_ref_deleted - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment