? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Nov 2016

This PR expands the already merged #11911 to com_newsfeeds

Summary of Changes

Enables the new "Show Global Value" feature for all newsfeed forms.

Testing Instructions

Test the newsfeed form and the related menu item forms. All list elements with a "Use Global" entry should show the global value like this:
newsfeed

Exception: The robots field will not show the global value.

Note: If you get a message that some global values can't be found, try saving the component options.

Documentation Changes Required

None

avatar Bakual Bakual - open - 11 Nov 2016
avatar Bakual Bakual - change - 11 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category Administration com_newsfeeds Front End
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

can you change the title of the PR @Bakual doesn't seems right

avatar Bakual Bakual - change - 11 Nov 2016
Title
Enable show global value for "Show Associations"
Enable show global value for Newsfeeds
avatar Bakual Bakual - edited - 11 Nov 2016
avatar Bakual Bakual - change - 11 Nov 2016
Title
Enable show global value for "Show Associations"
Enable show global value for Newsfeeds
avatar Bakual
Bakual - comment - 11 Nov 2016

@andrepereiradasilva Done. Looks like I copied the wrong text into the title :(

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

Some issues in the news feeds menu items the character count is always "0" no matter what i add and doesn't show the global option.

image

image

also in new news feed
image

avatar Bakual
Bakual - comment - 11 Nov 2016

This is unrelated to this PR. Those fields have a default value of 0 specified, which means you never can use the global value here.
If we want to change that, we can do, but it needs testing of the parameter behavior. I'd prefer to do that in a different PR then.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

ok then, a different PR, but i think that value should work like the others, ie, use the global option by default

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

I have tested this item successfully on ee63ac3

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12864.

avatar andrepereiradasilva andrepereiradasilva - test_item - 11 Nov 2016 - Tested successfully
avatar Bakual
Bakual - comment - 11 Nov 2016

@andrepereiradasilva See #12869 for the character count.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

I have tested this item successfully on ee63ac3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12864.

avatar brianteeman brianteeman - test_item - 14 Nov 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - test_item - 15 Nov 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 15 Nov 2016

I have tested this item successfully on ee63ac3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12864.

avatar jeckodevelopment jeckodevelopment - change - 15 Nov 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 15 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12864.

avatar brianteeman brianteeman - change - 15 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 21:48:57
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - reference | 83b4f16 - 15 Nov 16
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar Bakual Bakual - head_ref_deleted - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment