? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
8 Nov 2016

Summary of Changes

This is basicly the same issue as #12820 but for field.

When creating a new field there is a check being made for ex: com_content.article.field.id, but since this is a new field, the id doesn't yet exist, so we should fallback to the field component asset in this case.

Testing Instructions

  • Code review
  • Apply patch
  • Check the published field when creating a new field, with or without core.edit.state permission in the component.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 8 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 8 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2016
Category Administration Components
avatar sanderpotjer
sanderpotjer - comment - 13 Nov 2016

I have tested this item successfully on f53753d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12827.

avatar sanderpotjer sanderpotjer - test_item - 13 Nov 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 13 Nov 2016

I have tested this item successfully on f53753d

Tested, also did code review, and it looks correct


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12827.

avatar ggppdk ggppdk - test_item - 13 Nov 2016 - Tested successfully
avatar brianteeman brianteeman - change - 13 Nov 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12827.

avatar brianteeman brianteeman - change - 13 Nov 2016
Milestone Added:
avatar brianteeman brianteeman - change - 13 Nov 2016
Labels Added: ?
avatar rdeutz rdeutz - reference | 2156baf - 15 Nov 16
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 21:44:36
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 15 Nov 2016
Category Administration Components Administration com_fields Components
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment