[#12826] - [ACL] [com_fields fields view] Correct when display batch button
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12826
- Diff
- andrepereiradasilva:patch-35
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is basicly the same problem as #12800.
The fields ACL for displaying the batch button is not correct. It's based on a context var.
As it is, it's trying to check ACL for an asset with the name of com_content.article (or com_users.user or com_contact.contact) when it should be checking the ACL of the component com_content (or com_users or com_contact).
This PR aims to correct that.
Testing Instructions
- Code review.
- Test if "Batch" button appears on com_fields fields (ex: Content -> Fields) when a user is not able to
core.createin the component. - Apply patch
- Repeat step 2, no button now
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
Please. folks, wait
PLT has not decided yet if com_fields is allowed or not to use com_categories, therefore also the batch.
I could not reproduce the issue. I'v tested it on a fresh Joomla installation:
- Created a new user and assigned it to the Administrator group
- Denied the Create permission in the Article Options
- Logged in on a private browser window with the new user.
With or without the patch on both cases the Batch button is not shown.
@infograf768 please don't tell people not to fix things as this PR has nothing to do with your com_categories problem in com_fields.
@laoneo it actually works because when checking com_content.article the asset is not found and then it's falling back to the component ACL (ex: com_content).
The fact it works as it is does mean it's done in the correct way. It should not work like that, the ACL check should be done properly.
Do this, and you will see it what i mean:
- Apply #12850 patch
- Enable global debug and debug system plugin
- Login as Administrator, go to any com_fields (ex: Content -> Fields) and check the debug console, "Log Messages" separator. You will see something like this:
So what did then do wrong on my end. I really did only these three steps on a fresh Joomla installation.
I have tested this item
Thanks for clarification @andrepereiradasilva
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12826.
zero-24
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels | |||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:43:36 |
| Closed_By | ⇒ | rdeutz |
| Category | Administration Components | ⇒ | Administration com_fields Components |
I have tested this item✅ successfully on 29af22d
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12826.