? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
7 Nov 2016

Summary of Changes

In com_templates style view there is invalid ACL checks, checking for com_menu component which does not exist. The name is com_menus, this PR corrects that.

Testing Instructions

Mainly code review, but you can test if edit a template style view continues to work and com_menus ACL is now respected.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 7 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2016
Category Administration Components
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
[ACL] [com_templates style view] Correct check when "All Menus" is selected
[ACL] [com_templates style view] Correct invalid check
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 7 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
[ACL] [com_templates style view] Correct check when "All Menus" is selected
[ACL] [com_templates style view] Correct invalid check
avatar sanderpotjer
sanderpotjer - comment - 13 Nov 2016

I have tested this item successfully on f760bcb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12818.

avatar andrepereiradasilva andrepereiradasilva - alter_testresult - 13 Nov 2016 - sanderpotjer: Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 17 Nov 2016

I have tested this item successfully on dc873a8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12818.

avatar jeckodevelopment jeckodevelopment - test_item - 17 Nov 2016 - Tested successfully
avatar brianteeman brianteeman - change - 17 Nov 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 17 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12818.

avatar brianteeman brianteeman - change - 17 Nov 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 17 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - change - 17 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-17 20:08:03
Closed_By rdeutz
avatar rdeutz rdeutz - close - 17 Nov 2016
avatar rdeutz rdeutz - merge - 17 Nov 2016
avatar rdeutz rdeutz - reference | 05d5fb3 - 17 Nov 16
avatar rdeutz rdeutz - merge - 17 Nov 2016
avatar rdeutz rdeutz - close - 17 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2016
Category Administration Components Administration com_templates Components

Add a Comment

Login with GitHub to post a comment