Please activate JavaScript in your browser.
?
Success
Success
continuous-integration/drone
the build was successful
Details
Success
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
Success
JTracker/HumanTestResults
Human Test Results: 2 Successful 0 Failed.
Details
User tests:
Successful:
Unsuccessful:
Summary of Changes
In com_templates style view there is invalid ACL checks, checking for com_menu
component which does not exist. The name is com_menus
, this PR corrects that.
Testing Instructions
Mainly code review, but you can test if edit a template style view continues to work and com_menus ACL is now respected.
Documentation Changes Required
None.
andrepereiradasilva
-
open
-
7 Nov 2016
andrepereiradasilva
-
change
-
7 Nov 2016
joomla-cms-bot
-
change
-
7 Nov 2016
Category
⇒
Administration
Components
andrepereiradasilva
-
change
-
7 Nov 2016
Title
Differences
…
[ACL] [com_templates style view] Correct check when "All Menus" is selected
[ACL] [com_templates style view] Correct invalid check
Labels
Added:
?
andrepereiradasilva
-
edited
-
7 Nov 2016
andrepereiradasilva
-
change
-
7 Nov 2016
Title
Differences
…
[ACL] [com_templates style view] Correct check when "All Menus" is selected
[ACL] [com_templates style view] Correct invalid check
andrepereiradasilva
-
alter_testresult
-
13 Nov 2016
-
sanderpotjer :
Tested successfully
jeckodevelopment
-
test_item
-
17 Nov 2016
-
Tested successfully
brianteeman
-
change
-
17 Nov 2016
Status
Pending
⇒
Ready to Commit
brianteeman
-
change
-
17 Nov 2016
brianteeman
-
change
-
17 Nov 2016
Status
Ready to Commit
⇒
Fixed in Code Base
Closed_Date
0000-00-00 00:00:00
⇒
2016-11-17 20:08:03
Closed_By
⇒
rdeutz
rdeutz
-
close
-
17 Nov 2016
rdeutz
-
merge
-
17 Nov 2016
rdeutz
-
merge
-
17 Nov 2016
rdeutz
-
close
-
17 Nov 2016
joomla-cms-bot
-
change
-
17 Nov 2016
Category
Administration
Components
⇒
Administration
com_templates
Components
Add a Comment
Login with GitHub to post a comment
I have tested this item✅ successfully on f760bcb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12818.