Feeling Lucky
?
[#12815] - [ACL] [com_menus items view] Correct check when "All Menus" is selected
- Closed
- 15 Nov 2016
- Medium
- Build: staging
- # 12815
- Diff
- andrepereiradasilva:patch-5
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The ACL check in com_menus items view, when all menus is selected, is wrong. It's getting the menutype id from the state (0 in this case) and not from the real menu type id of each of those menu items.
This PR corrects that.
Testing Instructions
Mainly code review.
But you can test com_menus items view still works fine and ACL in when all menus is selected is now working fine.
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
ggppdk
- comment
- 13 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12815.
andrepereiradasilva
- comment
- 13 Nov 2016
RTC?
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
zero-24
- comment
- 13 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12815.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:41:36 |
| Closed_By | ⇒ | rdeutz |
| Category | Administration Components | ⇒ | Administration com_menus Components |
I have tested this item✅ successfully on f760bcb
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12815.