[#12814] - JFormAbstractlist ignores 0 as option text
- Fixed in Code Base
- 8 Nov 2016
- Medium
- Build: staging
- # 12814
- Diff
- Bakual:Allow0AsoptionText
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Currently JFormAbstractlist (which means all list type formfields) ignores an option text set to 0. It will use the option value instead.
Summary of Changes
Changing the boolean check to a check against an empty string
Testing Instructions
Create or adjust an existing list formfield definition and add an option with any value but 0 as text to it. For example adjust the state field in the article.xml (https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_content/models/forms/article.xml#L31-L43) and add
<option value="text-0">0</option>
<option value="text-empty"></option>
to the options list. It should look like this then:
<field name="state" type="list" label="JSTATUS"
description="JFIELD_PUBLISHED_DESC" class="chzn-color-state"
filter="intval" size="1" default="1"
>
<option value="1">
JPUBLISHED</option>
<option value="0">
JUNPUBLISHED</option>
<option value="2">
JARCHIVED</option>
<option value="-2">
JTRASHED</option>
<option value="text-0">0</option>
<option value="text-empty"></option>
</field>
Check the field in the item form (in our example the article state).
Before PR you get two additional entries text-0 and text-empty.
After PR you get two additional entries 0 and text-empty.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12814.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12814.
| Milestone |
Added: |
||
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-08 09:01:52 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 93c8fd2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12814.