I think this "notice" needs some work. it isn't clear that it refers to the Global Options for the component that are not visible on that page and not the options tab directly below the message.
Even better would be a link in the message to the correct options screen.
Also I understand technically why we will have this message on an upgraded site but surely it should never be present on a new install.
Which part
that the message needs a link
or
that the message shouldnt ever be there on a new install
Or both
On 5 November 2016 at 22:56, andrepereiradasilva notifications@github.com
wrote:
yeah that's what i said before ...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12782 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8XyZht4eaDYbIqNn74R_CLo5JMP3ks5q7QmdgaJpZM4KqaM7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
i think there should be no message at all as said in the PR.
Having seen it in action I tend to agree - its very confusing and not a
good experience.
I still think there is no reason it should be needed on a new install
though - its highlighing a problem with the install data
On 5 November 2016 at 23:09, andrepereiradasilva notifications@github.com
wrote:
i think there should be no message at all as said in the PR.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12782 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bAmCfgg3jqF5Yl2GtY06dd-Ymybks5q7QyxgaJpZM4KqaM7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
For core extensions I agree with the install vs update behavior. However for 3rd party extensions, installs usually don't have any options prestored. Thus they need to save them initially before this feature will work.
Also keep in mind that the global options come from component, menu and/or global configuration options. That needs to be kept in mind when rewriting the message.
As said before, I don't have strong feelings to keep that message. I thought it may be helpful for the user, but if it is more confusing than helpful, lets remove it. Or if we can rewrite it to be more clear, lets do that
For core extensions I agree with the install vs update behavior
You are agreeing that it shouldnt ever happen on an install or you agree
with the current behaviour
On 6 November 2016 at 07:56, Thomas Hunziker notifications@github.com
wrote:
For core extensions I agree with the install vs update behavior. However
for 3rd party extensions, installs usually don't have any options
prestored. Thus they need to save them initially before this feature will
work.
Also keep in mind that the global options come from component, menu and/or
global configuration options. That needs to be kept in mind when rewriting
the message.As said before, I don't have strong feelings to keep that message. I
thought it may be helpful for the user, but if it is more confusing than
helpful, lets remove it. Or if we can rewrite it to be more clear, lets do
that? —
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12782 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8V32xwMvOKRDvmYPzItNkqigy-u3ks5q7YgugaJpZM4KqaM7
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I will spend some time and try to make sure that the options are all present and correct in the _extensions table for clean installs
You are agreeing that it shouldnt ever happen on an install or you agree
with the current behaviour
I agree that for core extensions it shouldn't happen on new installs as we save the component options already in the database during installation. If they are incomplete, they need to be fixed indeed.
For 3rd party extensions that option saving is usually not done during extension install, There you will have to save them initially or this feature will not work.
I am working on updating the install SQL for components and plugins. So far
60-70% of records need updating
I have this message when tried to create new menu item,
very confusing
I have this message when tried to create new menu item,
Try saving the options from the menu component
It is likely the "Show Page Heading" which haven't yet a saved value. One of those Brian wants to correct.
Note I am only able to correct this for new installs. It will still be
confusing for updates.
That is the first step maybe we can create a doc page that describe that for 3.7.0
I think the question is what is more confusing:
Depending on the answer we can remove or improve the message
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-11 08:29:07 |
Closed_By | ⇒ | Bakual |
yeah that's what i said before ...