Feeling Lucky
?
[#12781] - Don't add media version if media version is empty (now for css)
- Fixed in Code Base
- 6 Nov 2016
- Medium
- Build: staging
- # 12781
- Diff
- andrepereiradasilva:patch-25
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Don't add media version to stylesheets (css) if media version is empty.
This is exactly equal to #12716 (already merged), but now for stylesheets.
Testing Instructions
Simple test. Code review or:
- Add this to isis index.php
$this->SetMediaVersion(null);- Load any admin page and check page source, you will notice the resulting html is, for instance,
<link href="/administrator/templates/isis/css/template.css?" rel="stylesheet" />(note the question mark in the end) - Apply patch
- Refresh the page and notice there is no question mark now.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
jeckodevelopment
- comment
- 6 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12781.
jeckodevelopment
- comment
- 6 Nov 2016
@brianteeman i can see the SHA and i changed your test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12781.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 6 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12781.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-06 20:16:20 |
| Closed_By | ⇒ | rdeutz |
Tested successfully
@mbabker no sha :(
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12781.