[#12753] - database table #__extensions - Set enabled to 0 by default
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12753
- Diff
- pe7er:modulepositions-templates
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12751
Summary of Changes
This PR sets the default value for "enabled" in the database table "#__extensions" to 0.
Testing Instructions
Before PR
Create a new front-end template with some example module positions:
/templates/example/templateDetails.xml
<?xml version="1.0" encoding="utf-8"?>
<extension version="3.6" type="template" client="site">
<name>EXamPLe</name>
<version>1.0</version>
<creationDate>4 November 2016</creationDate>
<author>Peter Martin</author>
<positions>
<position>aaa</position>
<position>bbb</position>
<position>ccc</position>
</positions>
</extension>
In Joomla back-end: Extensions > Manage > Discover
Do not install the template.
Go to Extensions > Modules > create /edit a module,
and notice that the Module Positions of the Template that is not installed, are available.
After PR
Remove the Discovered but Uninstalled Template from the #__extensions table:
Install this PR and
Extensions > Manage > Discover
Do not install the template.
The Module Positions of the Uninstalled Template should not be visible in the Module Manager.
Note: If you install the template via Discover it should become enabled.
Extensions > Manage > Discover > Install the template
and test if it's available in Extensions > Templates and/or
check in the database in #__extensions if will the enabled field has been changed to 1.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql MS SQL Unit Tests |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
| Title |
|
||||||
| Labels |
Removed:
?
|
||
| Category | SQL Installation Postgresql MS SQL Unit Tests | ⇒ | SQL Administration Components Postgresql MS SQL Installation Unit Tests |
| Labels |
Removed:
?
|
||
Should discover do anything other than discover the template? - it should not be creating rows in database surely? isnt that the real problem here?
If you want to rewrite how that's tracked, have at it. Right now discover DOES add records to the database to tell Joomla it has found new extensions in the filesystem but they are not fully installed and that's how it keeps track of those discoveries.
Ouch - I thought Discover should just discover on visiting the page, and give a list, there is no need to really track anything, then when its installed that's when db entries should be written IMHO.
Followed the instruction and worked totally fine. The test was successful here.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12753.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12753.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12753.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:39:51 |
| Closed_By | ⇒ | rdeutz |
| Category | SQL Installation Postgresql MS SQL Unit Tests Administration Components | ⇒ | SQL Administration com_admin Postgresql MS SQL Installation Unit Tests Components |
I've created 3 SQL update files to correct the issue at existing sites