I have tested this item ✅ successfully on b304fb2

With default sample data and added the separator to a menu to see results in Module asignment. No issues and I see the added info with the mentioned labels. Not sure about the user story though.

I have tested this item ✅ successfully on b304fb2

Patch works as described.
Wonder if it is also possible to show also whether it concerns a external URL (the last option of system links), or even for all menu options.

I have contacted PLT to decide whether this should go into core or not.

@Luchen6 you right, i think i will add the label "URL"

@cpfeifer can I have your opinion about this PR from UX perspective, please?

Great stuff

1. Please add the External URL info as then you will have all the system links

2. @roland-d why is this a PLT decision. Has something changed

   ---

   _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12752.}

@jeckodevelopment why? This is really just a continuation of other similar PR that have either already been merged or are RTC

I think we should have a better way.
What we want is that the user does NOT assign a module to these system menu items as it is useless.
We should or not display them in this list, or make them unselectable.

@brianteeman Nothing changed, I just didn't see the use of this PR but as JM pointed out, modules can't be assigned to these menu items.

I am in favour of showing them but make them unselectable.

I think it will be confusing if they are not displayed but I agree that
they need to be identified in some way. This tag approach is a good one. So
would be making them unselectable

On 5 November 2016 at 11:21, infograf768 notifications@github.com wrote:

I think we should have a better way.
What we want is that the user does NOT assign a module to these system
menu items as it is useless.
We should or not display them in this list, or make them unselectable.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12752 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YNlU_YdBgkoxr5DSEUKi6QAksQEks5q7GaxgaJpZM4Kpk8z
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

I have tested this item ✅ successfully on b304fb2

I have a patch ready that just will prevent these menu items from display.
I do not see what would be confusing not to see them in this precise display.

If you hide a menu item which has children how will you know the parent

On 6 November 2016 at 10:07, infograf768 notifications@github.com wrote:

I have a patch ready that just will prevent these menu items from display.
I do not see what would be confusing not to see them in this precise
display.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12752 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8Tg0syg_gmAp-FwyZnoF92TrMPi2ks5q7abHgaJpZM4Kpk8z
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

Want me to add a disable attribute on those items ?

If you hide a menu item which has children how will you know the parent

True.

I am in favor of this. What I see in the patch is kind of a mess, looks like a minor styling issue or maybe something on my end.

I imagine something along these lines is what we're after. I created a menu with a top level heading, then alternated content through the other system links and made this crude mockup. Basically, the label replaces the checkbox, and I think changing the text to de-emphasize it adds a visual cue. In this mockup I just made it a lighter color in PSD, it could be italics and a lighter color. Just something to indicate it's not available as a selection. A piece of documentation would be necessary and could be linked to from this area as well.

What I see in the patch is kind of a mess

That's a strong indication your structure in that site is wrong

That's why I mentioned it could be something on my end, I didn't spend a ton of time setting up a test environment. The created mockup is a direction I think will work regardless.

Any milestone ?

@Devportobello we typically only add a milestone when it is ready to commit (unless it is specifically not for the next release)

ok i understand

@Devportobello this PR needs tests now

I have tested this item ✅ successfully on 90a6986

I have tested this item ✅ successfully on 90a6986

Perfect! Thank you

RTC