Is this really the correct fix for the problem? It appears to be that either the page cache plugin is re-using options it shoudnt be using OR the page cache plugin should be managed from global config

I have tested this item ✅ successfully on 96fdb86

It's not just the page cache plugin. In theory these fields being hidden could cause issues for anything that's overriding the global cache config and caching anyway using the configured cache handler (like our own template for joomla.org does with the HTML elements fetched from the CDN).

So there's a twofold issue here. One is site admins need to be able to ensure these configs are good even if global cache is disabled. Two is extensions which are caching even when global cache is disabled need to take extra precautions to not fail miserably (something they can do a bit better with 3.6.3+ with the storage handler factory throwing more specialized Exceptions).

The problem IMHO is as it is we can't having caching enabled. but only for components/plugins, ie, not using conservative/progressive caching.

So we:

• either do this PR
• We add a new caching option "Enabled" (confunsing IMO) to global config that will only be used by cache plugins that would check if that setting is enabled.
• other

The thing is when you have page cache enabled you probably don't need the other caching option IMO so you diable cache in global config, but page cache plugin reads the values from global config.

asking @mbabker opinion on this (when you have time)

UPDATE: ups seems michael responded while i was writing

OK so that means
1. we do need to remove the showon
2. we need to re-evaluate the order and labels of the existing fields in global configuration

2 will make it clearer that some of the fields are options that apply across joomla and not just for the 3 cache options presented in global config

This PR's good as is for a starting point. As far as changing labels, the only thing I can immediately suggest is that the Cache Handler field be a little more clear that this is the default handler used by all of Joomla regardless of whether caching is enabled in the global config.

Maybe "Cache" needs to be "System Cache" or something like that. But don't know.

yes I was thinking that it was the "Cache" label that needed changing (not
quite sure what to)

And then maybe add a separator between that field and the others

On 3 November 2016 at 22:16, andrepereiradasilva notifications@github.com
wrote:

Maybe "Cache" needs to be "System Cache" or something like that. But don't
know.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12742 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8ca3u3TquBy0MSMMge3clC2OQmG5ks5q6l1SgaJpZM4Ko9yF
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

And probably be the last one.
Should we merge this as it is (one more test) since it solve the issue itself, and them do the rest?

If you can move the cache field to the end in this PR then it will be
quicker/easier I think

On 3 November 2016 at 22:20, andrepereiradasilva notifications@github.com
wrote:

And probably be the last one.
Should we merge this as it is (one more test) since it solve the issue
itself, and them do the rest?

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12742 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b3mRLgQKaZNoMYzf22JbjFNObveks5q6l4hgaJpZM4Ko9yF
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

ok, done (also done micro cs changes)

humm many we need to change the session part to to be consistent

Proposal for Cache And Session

• Handler
  • (Handler config)
• Time
• Other 1
• Other 2

Handler
Time

Platform

System Cache

??

ok, this way. is this ok? if so please test

can we change the string as well?

please propose a PR to my branch https://github.com/andrepereiradasilva/joomla-cms/blob/patch-21/administrator/components/com_config/model/form/application.xml with the string changes

I have tested this item ✅ successfully on acac248

@ggppdk please test again

I have tested this item ✅ successfully on acac248

Tested, also looks good on code review of showon="..." changes for memcache / memcached / redis that removed: caching:1,2[AND]

thanks

I have tested this item ✅ successfully on acac248

RTC