Some pictures so it's more clear ?

Before:

After:

agree 100%

a required field should never be buried on a tab

On 3 November 2016 at 19:51, Thomas Hunziker notifications@github.com
wrote:

Some pictures so it's more clear ?

Before:
[image: before]
https://cloud.githubusercontent.com/assets/1018684/19982656/31eca2c6-a207-11e6-9cf5-e077645310dc.PNG
[image: before2]
https://cloud.githubusercontent.com/assets/1018684/19982661/39469842-a207-11e6-9cc5-6a7fc9ec4b0a.PNG

After:
[image: after]
https://cloud.githubusercontent.com/assets/1018684/19982664/3e101344-a207-11e6-9420-147124423a31.PNG

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12740 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8TXTu1S2CbKV7WR6E7EMBX_djvXeks5q6js5gaJpZM4Ko1i1
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

I have tested this item ✅ successfully on 77457a4

Oh wait a moment. I remember discussing this one before. See joomla-projects/custom-fields#22
By default the label is autocompleted with the value of the field name.

It originally was on the first tab and it was very confusing.

Just watch the label get autocompleted as you have typed the field name

TBH I didnt think the field should even exist at all. The use case presented joomla-projects/custom-fields#22 (comment) suggested that the only time you might change it was for customisation of the visual presentation in which case it made sense to move it to the tab responsible for visual presentation.

I have tested this item ✅ successfully on 77457a4

Maybe change the description of 'label':

Label of field is used when editing field in forms and when viewing field values. This is different than field title, that is only used in backend fields management

It is confusing for sure.
I think the label and description have to stay together as the description is the tooltip of the label.
I know the label is autocompleted, which is a bit strange by itself. Personally I would make the label optional and use the title if the label is not specified. Then it could go to the option tab.
But as long as it has the required flag, I don't want to have it on third tab and the description on the first one.

I still think it should not be required and it should be on the third tab
and the code should use the field name by default

On 3 November 2016 at 22:57, Thomas Hunziker notifications@github.com
wrote:

It is confusing for sure.
I think the label and description have to stay together as the description
is the tooltip of the label.
I know the label is autocompleted, which is a bit strange by itself.
Personally I would make the label optional and use the title if the label
is not specified. Then it could go to the option tab.
But as long as it has the required flag, I don't want to have it on third
tab and the description on the first one.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12740 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eQzVaDe_stlR4wz5s0fThC68DWZks5q6mbCgaJpZM4Ko1i1
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

The label is a very important aspect as it may become a constant for a language string.
As well for the description. They should be together, as we do in the xmls.
As we do not accept any type of text as labels (parse ini), taking it off would be a huge mistake.

So what to do with this PR?

For me, should be RTC

RTC

RTC

Why did you change the default_value parameter to a text field? What's the benefit?

From the PR description:

Changed the type of the default value field from textarea to text. I can't think of a usecase where the default value would span multiple rows and thus text should be sufficient always.

I can't think of a usecase where the default value would span multiple rows and thus text should be sufficient always.

Not always

In most cases "text" is enough to contain the default value,
but some fields may need a larger default value, e.g. an editor field or 3rd party fields,
for these cases "text" will make it a little difficult to edit

• it will depend on user's / site's needs

a default value of type "textarea" with 2 rows that user can drag to enlarge would be best

I think having a two line default value is looking bad on the form and gives wrong clues to the user. But if you see a use case and think it's worth having a textarea to enter a 1, then go ahead and change it back :)

I think having a two line default value is looking bad on the form and gives wrong clues to the user ...

You are right about this, great majority of fields will need 1 line text box as default value
that is why it would have been best if default value parameter was in the XML file of the field type,
instead of this being a common parameter, and indeed the great majority of fields should need only "text"

also other reason for it to be in the XML file is:

• custom parameter description about default value
• and for some fields it can "default values" and not "default value"

I can't remember, but there was a reason I put is as text area, PR which reverts it back, #12811.