Feeling Lucky
?
[#12720] - Add stylesheet version to all css files and replace deprecated stylesheet signatures usage
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12720
- Diff
- andrepereiradasilva:mediaversion-css
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #9638 (css part).
Summary of Changes
This does for css the same that was done in #12373 for js.
So, this PR replaces all deprecated stylesheets methods signature usage across the CMS.
Also:
- adds stylesheet version to all js files to solve #9638
- use the api in conditional ie statements
Testing Instructions
- Code review.
- Use latest staging
- Apply #12375 and them this patch
- Navigate in the frontend/backend/installation (several template). Confirm all is working fine and check all external css files are loaded and with media version
Documentation Changes Required
None.
Notes
Unit tests will fail until #12375 is merged.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components com_media Templates (admin) Front End Installation Layout Libraries |
brianteeman
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12720.
andrepereiradasilva
- comment
- 4 Nov 2016
@brianteeman just updated branch since the other pr is now merged to fix the unit tests. Please Mark again as tested with success. No changes.
jeckodevelopment
- comment
- 4 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12720.
brianteeman
- comment
- 4 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12720.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 4 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12720.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 10:07:02 |
| Closed_By | ⇒ | rdeutz |
@andrepereiradasilva Travis still doesn't like you ;)