Feeling Lucky
?
[#12719] - [com_fields]remove captcha from field types
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12719
- Diff
- brianteeman:captcha_field
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
As discussed here #12703 there is no point at all in having captcha as a custom field type. And even if you have it the way fields is coded it doesnt work as th display in admin and required fields do not work
this PR removes the captcha field type from the list of custom field types that can be created
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Components |
laoneo
- comment
- 3 Nov 2016
Perfect.
For a none developer you do handle git very well!!
| Category | Administration Components | ⇒ | com_fields Libraries |
laoneo
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12719.
alikon
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12719.
PhilETaylor
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12719.
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- comment
- 3 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12719.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 09:12:28 |
| Closed_By | ⇒ | rdeutz |
brianteeman
- comment
- 4 Nov 2016
Thanks
It would be better to remove on this line https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/form/field/captcha.php#L17 the code
implements JFormDomfieldinterface. Then you don't need to add it to the blacklist which is a workaround anyway.