Feeling Lucky
?
[#12716] - Don't add media version if media version is empty
- Fixed in Code Base
- 3 Nov 2016
- Medium
- Build: staging
- # 12716
- Diff
- andrepereiradasilva:patch-25
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Don't add media version if media version is empty.
Testing Instructions
Simple test. Code review or:
- Add this to isis index.php
$this->SetMediaVersion(null);- Load any admin page and check page source, you will notice the resulting html is, for instance,
<script src="/administrator/templates/isis/js/template.js?"></script>(note the question mark in the end) - Apply patch
- Refresh the page and notice there is no question mark now.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
brianteeman
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12716.
Fedik
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12716.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-03 08:43:55 |
| Closed_By | ⇒ | zero-24 |
zero-24
- comment
- 3 Nov 2016
Merged Thanks!
tested successfully (sha missing)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12716.