[#12715] - Installation multilingual options are Red (error? danger?)
- Closed
- 13 Nov 2016
- Medium
- Build: master
- # 12715
Steps to reproduce the issue
Go to /installation/index.php?view=defaultlanguage&lang=en and check the multilingual button colors.
Expected result
Not red. Red usually means error or danger.
Actual result
System information (as much as possible)
Latest staging.
Additional comments
None.
| Labels |
Added:
?
|
||
| Category | ⇒ | Installation |
i don't think so, "No" is not bad also, is just an option
its not that simple in the installation - the css is not present (neither
is btn-group-yesno)
another example of where we need to review the red/green
On 2 November 2016 at 23:18, Lodder notifications@github.com wrote:
need to use btn-group btn-group-revered in the form field
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12715 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8b3nknCCQ4_pkWJSBySJzasvS-6mks5q6RpAgaJpZM4Kn0SY
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
i will take a closer look at this tomorrow - it will need new css in the installation template for certain
This is all done by JS and if you compare the relevant code in installation.js with template.js you will see the ordering etc is very different. Not just a case of adding a class to the xml
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12715.
| Status | New | ⇒ | Confirmed |
I have tried and failed to resolve this
If we agree that we should not use here Green and Red as they correspond to Positive and Negative in general in our UI, I propose to highlight the Option selected with a neutral color.
My patch is ready for this, if you agree. It overrides the bootstrap default only for these specific fields.
I chose Orange as neutral color. It could be a grey too.
Here is what I get:
we don't need to wait for 4.0...
right ...
3.7 is supported for at least two years we should not put things off that
can be fixed in 3.7
@infograf768 I think a shade of blue is more common for a neutral colour
@brianteeman
Would you be kind enough to post here the # value for that blue?
Would #6ca8ff be OK?
On my phone so hard to check but something like
I will use a shade of that.
Seems fine. Why is there a blinking cursor on the active button in your first screenshot?
ah fair enough
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-13 14:36:48 |
| Closed_By | ⇒ | infograf768 |
Set to "closed" on behalf of @infograf768 by The JTracker Application at issues.joomla.org/joomla-cms/12715
Closing as we have a patch #12879
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12715.
need to use
btn-group btn-group-reversedin the form field